feat(slab): implement basic action operations #1
Conversation
soonum
force-pushed
the
dt/feat/create_action
branch
6 times, most recently
from
0bf6a70 to
568ee0e
Compare
|
New HTTP routes in Slab must be shipped to production before to be able to have a green CI here. |
|
Regarding the huge number of lines in this PR, don't worry since the only files that matter are located in |
soonum
force-pushed
the
dt/feat/create_action
branch
from
568ee0e to
ddf7c8e
Compare
|
maybe skip code QL if it requires paying additional stuff (looks like the workflow indicates that it is the case) |
soonum
force-pushed
the
dt/feat/create_action
branch
2 times, most recently
from
50faee4 to
4e9eb4a
Compare
soonum
force-pushed
the
dt/feat/create_action
branch
13 times, most recently
from
9d651d1 to
73812fc
Compare
soonum
force-pushed
the
dt/feat/create_action
branch
12 times, most recently
from
8c66789 to
7064ffa
Compare
soonum
force-pushed
the
dt/feat/create_action
branch
10 times, most recently
from
513f0e4 to
02d2162
Compare
| } | ||
| } | ||
|
|
||
| async function removeTask(taskId) { |
There was a problem hiding this comment.
tasks are not auto removed by slab once done ?
There was a problem hiding this comment.
No because one might want to know when a task is finished. Due to the asynchronous nature of such request, Slab cannot endorse the responsibility of removing a task as soon as it's done.
There was a problem hiding this comment.
hmm, I guess I kind of see it, but this means people calling the API need to do the clean up which seems fragile, I'm guessing it's a bit of work to get that on the Slab side but later down the line could we maybe do a query on the task status and if Slab sees that the status it returns is "done" then it removes the task on behalf of the requester
There was a problem hiding this comment.
with a timeout where the task is removed eventually like after 10 minutes
There was a problem hiding this comment.
do you want me to create an issue for this ? @soonum
There was a problem hiding this comment.
I agreed on your idea. That's a clever way to deal with the problem.
And yes, you can create an issue for this.
This consist in a simple "start" and "stop" mode for the action.
soonum
force-pushed
the
dt/feat/create_action
branch
from
02d2162 to
fd3f51f
Compare
| if (config.input.subnetId) { | ||
| payload.subnet_id = config.input.subnetId | ||
| } | ||
| if (config.input.securityGroupIds) { | ||
| payload.security_group_ids = config.input.securityGroupIds | ||
| } |
There was a problem hiding this comment.
are those already optional in Slab ?
This consist in a simple "start" and "stop" mode for the action.